Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take CST node boundaries into account for formatting #1629

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

ydaveluy
Copy link
Contributor

@ydaveluy ydaveluy commented Aug 14, 2024

Closes #1571

Do not perform formatting if the previous node ends after the current node starts.

@ydaveluy
Copy link
Contributor Author

This PR fix issue #1571

@msujew msujew changed the title do not perform formatting if the previous node ends after the current node Take CST node boundaries into account for formatting Aug 14, 2024
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks 👍

@msujew msujew merged commit 245336b into eclipse-langium:main Aug 14, 2024
4 checks passed
@msujew msujew added this to the v3.2.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatter removes first option in alternation rules
2 participants